-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alert_muting_rule): Add action_on_muting_rule_window_ended
attribute in newrelic_alert_muting_rule
Terraform Resource
#2783
Conversation
… handlers in alert muting rule
end_behaviour
attribute in newrelic_alert_muting_rule
Terraform Resource
…for terraform provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
end_behaviour
attribute in newrelic_alert_muting_rule
Terraform Resourceend_behaviour
attribute in newrelic_alert_muting_rule
Terraform Resource
@Aashirwadjain please add documentation changes (I've pointed where the documentation is to be added below), without which customers would not be aware of the addition of this new attribute. terraform-provider-newrelic/website/docs/r/alert_muting_rule.html.markdown Lines 48 to 57 in 25894e4
|
@Aashirwadjain in addition, please add relevant changes to integration tests, to make sure this new attribute is also part of the configuration that is created, read, and updated by the integration test for muting rules. Please see the following file, add wherever appropriate. By this, I mean - you don't have to add the attribute to all tests, just make sure the attribute is added wherever needed to make sure atleast one test fully covers this attribute too, along with other attributes of the resource (during create, read, update). |
@Aashirwadjain one occurrence that you will also find while testing your changes :) Screen.Recording.2024-12-19.at.12.18.13.AM.mov
Think of why this is happening, and what needs to be added/deleted/fixed in the code to prevent this occurrence. Fixing this is important, otherwise this would affect current customers using this Terraform resource without the new attribute (if these changes are merged without the fix, they would see a change upon Please rigorously test your changes to help fill such gaps :) |
…muting_rule_window_ended and validation method
…ement typecasting
…to alert muting rule test cases
…bute to newrelic_alert_muting_rule documentation
Thanks for suggestions @pranav-new-relic, Following changes are made accordingly:
|
…window_ended attribute in docs
…NewRelicAlertMutingRuleBasic method
…ourInput test method
…indow_ended attribute
end_behaviour
attribute in newrelic_alert_muting_rule
Terraform Resourceaction_on_muting_rule_window_ended
attribute in newrelic_alert_muting_rule
Terraform Resource
we should be good to merge once the requested changes are done (and further reviewed by VIshal/me), but
|
Description
action_on_muting_rule_window_ended
attribute in thenewrelic_alert_muting_rule
Terraform resource aims to enhance the functionality of muting rules within New Relic's alerting system using terraform.action_on_muting_rule_window_ended
is added to MutingRule Schema Resource and handler methods.newrelic_alert_muting_rule
: Support for Muting Rule "End Behaviour" #2774Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.